Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove maistra related things from molecule tests #716

Merged
merged 1 commit into from
Nov 3, 2023
Merged

remove maistra related things from molecule tests #716

merged 1 commit into from
Nov 3, 2023
+1 −193

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli self-assigned this Nov 1, 2023
@jmazzitelli jmazzitelli force-pushed the ossm-4962-remove-maistra-molecule branch from 2ed035d to 5485f01 Compare November 2, 2023 22:47
@jmazzitelli jmazzitelli marked this pull request as ready for review November 3, 2023 14:57
jshaughn
jshaughn approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, approving but make sure it passes, I didn't run.

@jmazzitelli
Copy link
Contributor Author

This passes, so all is good: make -e MOLECULE_SCENARIO="default metrics-test" molecule-test

@jmazzitelli jmazzitelli merged commit 8ee6504 into kiali:master Nov 3, 2023
1 check passed
@jmazzitelli jmazzitelli deleted the ossm-4962-remove-maistra-molecule branch November 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 24-13 | Kiali v2.0.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @jshaughn